AminetAminet
Search:
82087 packages online
About
Recent
Browse
Search
Upload
Setup
Services

util/dir/BrowserII-Patch.lha

Mirror:Random
Showing:ppc-amigaosgeneric
No screenshot available
Short:Patch BrowserII bug in ParsePattern()
Author:Alex Carmona
Uploader:Alex Carmona <AmigaOne theworld net>
Type:util/dir
Version:3.10
Requires:util/dir/BrowserII.lha
Architecture:m68k-amigaos
Date:2008-05-17
Download:http://aminet.net/util/dir/BrowserII-Patch.lha - View contents
Readme:http://aminet.net/util/dir/BrowserII-Patch.readme
Downloads:1700
This archive contains a patch for BrowserII 3.09 which changes the size
of the ParsePattern() DOS function buffer from 32 to 64.

To avoid confusion the patch also bumps the revision in the version
string from 3.09 to 3.10 and updates the date to May 14th 2008.

Under OS4 BrowserII 3.09 fails with filenames longer than 15 chars, when
using the Duplicate, Copy As, Move As, and Rename functions.

This is a bug in BrowserII. My guess is the authors misread the AmigaOS
autodocs and didn't realize that ParsePattern() must request a buffer
size *twice* the string length (+1 for the null termination).

Under OS3.x dos.library didn't check the buffer size and allowed the
function to return normally, potentially trashing some memory and
causing random crashes later, while in OS4 the library checks the size
and returns failure if the buffer is too small.

I don't have the source code for BrowserII and was unable to locate
Silvain Rougier, the surviving co-author, but I use that program for
everything related to files, and it's so convenient that I want to keep
using it as long as possible, so the only way to fix that issue was to
modify the compiled binary with an HEX editor (FileX).

BrowserII only allows filenames up to 30 chars in its requesters, so
this patch won't help with longer filenames but at least it should
prevent memory corruption in OS3.x and allow more than 15 chars in OS4.


Contents of util/dir/BrowserII-Patch.lha
 PERMSSN    UID  GID    PACKED    SIZE  RATIO METHOD CRC     STAMP          NAME
---------- ----------- ------- ------- ------ ---------- ------------ -------------
[generic]                 4410    5061  87.1% -lh5- 3875 May 16 19:33 BrowserII-Patch.info
[generic]                 4117    4908  83.9% -lh5- 311a May 16 19:33 BrowserII-Patch/B2-Patch.readme.info
[generic]                  202     220  91.8% -lh5- ad18 May 15 22:18 BrowserII-Patch/BrowserII.pch
[generic]                 9285   14636  63.4% -lh5- e89d Jun  3  1995 BrowserII-Patch/spatch
[generic]                 1065    2133  49.9% -lh5- fd59 May 17 01:17 BrowserII-Patch/B2-Patch.readme
---------- ----------- ------- ------- ------ ---------- ------------ -------------
 Total         5 files   19079   26958  70.8%            May 17 06:52

Aminet © 1992-2017 Urban Müller and the Aminet team. Aminet contact address: <aminetaminet net>